GNU OCTAVE IOS CODE
GNU OCTAVE IOS WINDOWS

GNU OCTAVE IOS WINDOWS

However, on Windows systems, you may be returning a different string from the one that is passed in. However, it may only be the cases where you have something like To store the result of get_ASCII_filename in a temporary variable first. Octave::sys::get_ASCII_filename (ff).c_str () This looks like it might be a problem with the lifetime of temporary variables? Probably a common function to do this job would also help with understanding and future maintenance.

GNU OCTAVE IOS CODE

This code appears twice (copy and paste, apparently). I can't quickly understand what that FIXME comment means, for example. Then it might be more obvious from the code what is happening. So instead of s_name, wchar_name or ascii_name or similar. I know I'm probably partly to blame for these bad tmp names, but it would probably also help if we consistently used more meaningful variable names here. Why was S_NAME used in the call to H5Fopen, but NAME used in the call to H5Fcreate? This is the kind of thing I was asking about in comment #4. accessible folder, close the file move and rename usingДЇile_id = H5Fcreate (name, H5F_ACC_TRUNC, octave_H5P_DEFAULT,ДЇile_id = H5Fcreate (s_name, H5F_ACC_TRUNC, octave_H5P_DEFAULT, FIXME: For Windows, create a file with an ASCII name in an If (mode & std::ios::app & H5Fis_hdf5 (s_name) > 0)ДЇile_id = H5Fopen (s_name, H5F_ACC_RDWR, octave_H5P_DEFAULT) Octave::sys::get_ASCII_filename (std::string (name)).c_str () ДЇile_id = H5Fopen (s_name, H5F_ACC_RDONLY, octave_H5P_DEFAULT) In the meantime I pushed the rest of your changes here to fix the immediate issue: Since this is the only place where 'check_gzip_magic' is called, we could remove 'get_ASCII_filename' from there and do the above change instead. So I did the 'conversion' to an ASCII file name inside 'check_gzip_magic'. I tried to do the 'conversion' as close as possible to the actual operation on the file system. + use_zlib = check_gzip_magic (ascii_fname)

With respect to the other similar change in -319,11 +323,11 get_file_format (const std::string& fnam I might have a look at this later (different bug). With your change H5Fcreate might create the file in a wrong location or with a wrong name. However, I couldn't figure out how I could trigger these parts of the code. The FIXME outlines a way that might work for these file locations with H5Fcreate. It cannot help if a function relying on the ANSI WinAPI tries to create a file in a location that is only accessible with the Unicode WinAPI. The function get_ASCII_filename can help if a function relying on the char WinAPI (MS calls that the ANSI WinAPI) tries to read from a location that is only accessible with the wchar WinAPI (Unicode WinAPI in MS speak).

Gnu octave ios